[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [coldsync-hackers] Re: Real life experiences with netsync



> > Anyway, what I'm saying is that I'm not the only one who has
> > requested this feature, and I needed it so badly that I'm
> > essentially anchored to a version of coldsync for which a patch
> > could be found to give it to me.
>
> > So along with the CVS fixes for inetd operation, yes, this would be my
> > personal feature request.
>
> Ok, you sold it. I'll try to come up with an implementation later
> this week.

Great!  Would it help to give you a patch against the 2.2.5 that implements
it?
In fact, in case it might (saving me another round trip to the mailing
list),
here is my patch against 2.2.5 which provides homedir support for a single
coldsync user.

The real beauty of it is that the netsync ports are >1024, so coldsync CAN
run as its own user.  The inetd patches will just make this all the sweeter.

... and now that I look at it, it seems to be integrated with a patch to add
UserID and UserName headers to the conduit header list.  I know there has
been effort in the realm of expanding the headerlist conduits receive
anyway, so I'm not going to worry about supplying code for it... it's likely
so ancient as to be embarrassing at this point.

(but I'll post if asked :-)


The whole of the actual HOMEDIRS patch is:

diff -uwr coldsync-2.2.5/src/coldsync.c coldsync-2.2.5-save/src/coldsync.c
--- coldsync-2.2.5/src/coldsync.c	Wed Nov 28 10:48:44 2001
+++ coldsync-2.2.5-save/src/coldsync.c	Sat Mar  2 05:18:57 2002
@@ -2467,7 +2466,7 @@
 		 * specify a directory. Use the default (~/.palm).
 		 */
 		strncpy(palmdir,
-			mkfname(userinfo.homedir, "/.palm", NULL),
+			mkfname(userinfo.homedir, "/", p_username, NULL),
 			MAXPATHLEN);
 	}
 	MISC_TRACE(3)

<... a few minutes later>

I'm looking now at CVS, and that line has moved to sync.c, starting at line
650.  I would contribute further but there is the config mechanism which I
don't know to account for.  It would make more sense as a .coldsyncrc option
than as a commandline switch, altho it might go both places.  You know
better than I.

L8r,
Rob


-- 
This message was sent through the coldsync-hackers mailing list.  To remove
yourself from this mailing list, send a message to majordomo@thedotin.net
with the words "unsubscribe coldsync-hackers" in the message body.  For more
information on Coldsync, send mail to coldsync-hackers-owner@thedotin.net.