RE: [coldsync-hackers] send-mail conduit fix

["Brian Johnson" <bjohnson@jecinc.on.ca>]

Sorry, I didn't save the original version to do a diff.

I changed
       next unless $PDB->{appinfo}{categories}[$record->{category}]{name}
               eq $HEADERS{"Outbox-name"};

to
       next unless $PDB->{appinfo}{categories}[$record->{category}]
               eq $HEADERS{"Outbox-name"};

and it looked like it worked, but now with the new p5-Palm, the original
seems to work (and not the revised version)


BTW - is there a sync flavor of this conduit?  A sync flavor could allow the
send of the email, then delete it from the Palm directly (all in one sync)


-----Original Message-----
From: owner-coldsync-hackers@lusars.net
[mailto:owner-coldsync-hackers@lusars.net]On Behalf Of Andrew
Arensburger
Sent: Friday, February 08, 2002 8:36 AM
To: coldsync-hackers@lusars.net
Subject: Re: [coldsync-hackers] send-mail conduit fix


On Thu, Feb 07, 2002 at 04:40:32PM -0500, Brian Johnson wrote:
> My copy of send-mail had the following lines:
>
> foreach $record (@{$PDB->{records}})
> {
>         # Skip everything except the Outbox folder
> #       next unless $PDB->{appinfo}{categories}[$record->{category}]{name}
> #               eq $HEADERS{"Outbox-name"};

	This is nonstandard. In my version, the last two lines above
aren't commented out.

> I found that it wouldn't work until I removed the {name} and left it as
>
> foreach $record (@{$PDB->{records}})
> {
>         # Skip everything except the Outbox folder
> #       next unless $PDB->{appinfo}{categories}[$record->{category}]{name}
> #               eq $HEADERS{"Outbox-name"};

	A few comments: first of all, these two versions are exactly
the same. What did you change? (In the future, please consider using
'diff -u' for patches, instead of describing them in natural
language). Secondly, the last two lines above are commented out, so no
change you make to them will have any effect.
	Lastly, if you meant to say

	next unless $PDB->{appinfo}{categories}[$record->{category}]
		eq $HEADERS{"Outbox-name"};

Why would you do that? $PDB->{appinfo}{categories}[$i] is a
reference-to-hash, so it'll never be equal to the inbox name.
	Are you using the latest version of p5-Palm from
http://www.ooblick.com/software/coldsync/ (not the version from CPAN) ?

--
Andrew Arensburger                      This message *does* represent the
arensb@ooblick.com                      views of ooblick.com
	  Today I will surround myself with unhealthy people
		 so that I may feel superior to them.

--
This message was sent through the coldsync-hackers mailing list.  To remove
yourself from this mailing list, send a message to majordomo@thedotin.net
with the words "unsubscribe coldsync-hackers" in the message body.  For more
information on Coldsync, send mail to coldsync-hackers-owner@thedotin.net.


-- 
This message was sent through the coldsync-hackers mailing list.  To remove
yourself from this mailing list, send a message to majordomo@thedotin.net
with the words "unsubscribe coldsync-hackers" in the message body.  For more
information on Coldsync, send mail to coldsync-hackers-owner@thedotin.net.