Re: [coldsync-hackers] minor bugs

[Andrew Arensburger <arensb+CShackers@ooblick.com>]

On Mon, Oct 29, 2001 at 09:44:00AM -0500, Matthew C. Weigel wrote:
> libpconn/slp.c makes the mistake of bypassing pconn->io_close(),
> calling close() on pconn->fd directly, in slp_{read|write}() (lines 168
> and 501 in 2.2.2).

	Thanks for the pointer.
	Bleah, I don't think this is as simple as it looks: it might
be necessary to rethink that particular bit of error-recovery.

> I'm not sure what format ya'll want fixes in, the trivial fix is to
> simply call pconn->io_close(pconn) instead, and not set pconn->fd to -1
> after.

	The preferred format is a unified-format patch, produced with
'diff -ruN oldversion newversion'.

-- 
Andrew Arensburger                      This message *does* represent the
arensb@ooblick.com                      views of ooblick.com
			   Neutral Greedy.
This message was sent through the coldsync-hackers mailing list.  To remove
yourself from this mailing list, send a message to majordomo@thedotin.net
with the words "unsubscribe coldsync-hackers" in the message body.  For more
information on Coldsync, send mail to coldsync-hackers-owner@thedotin.net.